Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly get child jobs #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: correctly get child jobs #37

wants to merge 1 commit into from

Conversation

markwaldkat
Copy link

Before it was checking for a key called name although the dependent jobs are under the key job:

            "depends_on": [
                {
                    "on": [
                        "finished"
                    ],
                    "job": "generator/vsystem-images-build_stage"
                }
            ],

Leaving the old check for the key name though.

markwaldkat
markwaldkat commented Apr 20, 2020
View reviewed changes
Copy link
Author

@markwaldkat markwaldkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure right now, if this also adds all jobs a job depends on instead of all jobs that are dependent on the specified one.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markwaldkat @CLAassistant @wamdo